Ryan Smith

Results 81 comments of Ryan Smith

Yeah I'd recommend checking if it's there and setting it to `null` if not.

I can see four uses of the event's id. 1. [/src/transformer/events/mod_quiz/attempt_viewed.php#L37](https://github.com/xAPI-vle/moodle-logstore_xapi/blob/master/src/transformer/events/mod_quiz/attempt_viewed.php#L37) 1. [/src/loader/lrs.php#L70](https://github.com/xAPI-vle/moodle-logstore_xapi/blob/master/src/loader/lrs.php#L70) 1. [/src/transformer/handler.php#L46](https://github.com/xAPI-vle/moodle-logstore_xapi/blob/master/src/transformer/handler.php#L46) 1. [/classes/task/emit_task.php#L46](https://github.com/xAPI-vle/moodle-logstore_xapi/blob/master/classes/task/emit_task.php#L46) Let me know if there are any other uses. I think the first...

Hey @trewq, thanks for this, just assigned you. We do have a couple of tests for `send_response_choices` (linked below). Those tests may serve as a useful example for the others....

Sounds good thanks @caperneoignis 👍

Which events would require this change and how would it effect the statements @davidpesce?

Yeah very annoying, to do it manually, I have to wait for the CI tool to finish two builds (for master and then the release tag that's automatically made from...

Interesting, I think you might be right with both of those. I believe when I started making the test data I used numbers instead of strings because I was creating...

If we don't want to replicate that, but we want to use their extension, then JISC need to change that before we implement it differently here.

I think @andrewhickey had an issue with that.

Which events was this intended to be added to @garemoko?