Ryan McKinley

Results 64 comments of Ryan McKinley

does this mean we can get rid of the second wire dependency graph?

The other key part is getting the apiserver running at the specified apiVersion: https://github.com/grafana/grafana/blob/main/pkg/registry/apis/datasource/register.go#L125 I don't think that needs to be in the same PR -- but worth remembering

🤔 it may be better if we just remove the generic service/library/support The generic gRPC server was designed to allow "services" across grafana to inject contracts into a shared server...

yes -- just want to make sure the goal is to remove it as a generic service, but the ownership proposed in this PR LGTM.

what panel is this for? IIUC, this is an explore only config for custom panels to have a fixed height? My initial thought was that indicating preferred aspect ratio could...

I expanded the scope to try to use the generated typscript in the frontend... it seems to work 🎉 but means we should be a bit more careful

> reflect as a new property in kindsys.#Structured pretty sure it needs to be above all that at the entity/summary/metadata level. The stuff that is currently encoded in: https://github.com/grafana/grafana/blob/main/pkg/services/store/entity/entity.proto#L20. The...

isn't this what we discussed about the custom fields? defined for a kind? -- it can live on the entity level and is currently defined by the summary builders eg,...

@ashharrison90 @mildwonkey -- i don't want this PR getting lost in the questionable state of entityAPI k8s future. As implemented it cleans up some ambiguity the preferences model. The questionable...