Ryan King

Results 16 comments of Ryan King

So I confirmed that the related image discovery feature does overwrite the base CSV related images. This was an unintended breaking change that I did not notice when implementing that...

I think there's a good case for both. It really comes down to if we want to say definitions in the base CSV are overrides or a deprecated way to...

By deprecated, I just meant that we don't officially recommend defining related images in the base CSV, not marking it for removal or anything. What I'm asking is if we...

@joelanford I am in favor of this approach in general. The only thing that I disagree with is giving precedence to discovered related image when its name conflicts with a...

@kaovilai > What's the point of appending containerRef on name collision if you are doing it on all collisions anyway? To make it obvious which are colliding? In the sample...

@kaovilai Okay I think I have a better idea of what you're pointing out now. The collision-resolution logic might not correctly resolve colissions when one or both related images are...

@kaovilai The correct procedure is defined in the [latest documentation](https://docs.openshift.com/container-platform/4.10/operators/operator_sdk/osdk-generating-csvs.html#olm-enabling-operator-for-restricted-network_osdk-generating-csvs). It instructs you to update the environment in `manager.yaml` and explains how to use them in the operator code. Let...

@kaovilai Okay so it looks like the related image dicovery feature introduced a breaking change that I didn't notice (and therefore document correctly). Short term will likely be a documentation...

@kaovilai Yup! Let's also move all discussion to the issue at #5763. I think what I propose there should work. If the team like the approach and you want to...

For reference, here's the very WIP PR on that: https://github.com/operator-framework/rukpak/pull/396/files