Ryan Thompson comments

Results 39 comments of


                                            Ryan Thompson

sklearn runinference regression example

Run Python 3.7 PostCommit

sklearn runinference regression example

Run Python 3.9 PostCommit

sklearn runinference regression example

@tvalentyn This looks ready to merge, the failing test is not the new test I added but rather the issue described here: https://github.com/apache/beam/issues/22605

sklearn runinference regression example

Run Python 3.9 PostCommit

sklearn runinference regression example

Run Python 3.9 PostCommit

[BEAM-12792] Install pipline dependencies to temporary venv

R: @tvalentyn

Fix failing BQ file loads test for Py37

This looks fine, but I don't really understand how this fixes the issue. Can you explain that in the comments of the test? It's not really clear why we would...

Add a tensorflow example to the run_inference_basic notebook

R: @AnandInguva

Add a tensorflow example to the run_inference_basic notebook

@damccorm @AnandInguva Can you take a look. I made a bunch of changes to this PR.

Changes CoGroupByKey typehint from List to Iterable

R: tvalentyn I want to talk about this before I submit. The coGroupByKey implementation specifically does make a dictionary with a [Key to list pairing](https://github.com/apache/beam/blob/cebf7388fc7a63f138f194ec0ed39e882ebfc72c/sdks/python/apache_beam/transforms/util.py#L245). However, the documentation is very...