beam
beam copied to clipboard
Fix failing BQ file loads test for Py37
Fixes #23264
Run Python 3.7 PostCommit
Run Python 3.8 PostCommit
Codecov Report
Merging #23283 (e543e52) into master (9287b92) will decrease coverage by
0.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #23283 +/- ##
==========================================
- Coverage 73.45% 73.45% -0.01%
==========================================
Files 718 718
Lines 95526 95528 +2
==========================================
+ Hits 70170 70171 +1
- Misses 24060 24061 +1
Partials 1296 1296
Flag | Coverage Δ | |
---|---|---|
python | 83.18% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
sdks/python/apache_beam/io/source_test_utils.py | 88.01% <0.00%> (-1.39%) |
:arrow_down: |
sdks/python/apache_beam/internal/metrics/metric.py | 93.00% <0.00%> (-1.00%) |
:arrow_down: |
...thon/apache_beam/ml/inference/sklearn_inference.py | 95.45% <0.00%> (-0.33%) |
:arrow_down: |
...ks/python/apache_beam/runners/worker/sdk_worker.py | 88.94% <0.00%> (-0.16%) |
:arrow_down: |
...thon/apache_beam/ml/inference/pytorch_inference.py | 0.00% <0.00%> (ø) |
|
...hon/apache_beam/ml/inference/tensorrt_inference.py | 0.00% <0.00%> (ø) |
|
sdks/python/apache_beam/ml/inference/base.py | 95.83% <0.00%> (+0.18%) |
:arrow_up: |
sdks/python/apache_beam/runners/direct/executor.py | 97.01% <0.00%> (+0.54%) |
:arrow_up: |
sdks/python/apache_beam/utils/interactive_utils.py | 97.56% <0.00%> (+2.43%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer
:
R: @ryanthompson591 for label python. R: @chamikaramj for label io.
Available commands:
-
stop reviewer notifications
- opt out of the automated review tooling -
remind me after tests pass
- tag the comment author after tests pass -
waiting on author
- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
Run Python PreCommit
Run Python 3.7 PostCommit
Run Python 3.8 PostCommit
Run Python 3.7 PostCommit
Run Python 3.7 PostCommit
This looks fine, but I don't really understand how this fixes the issue. Can you explain that in the comments of the test?
It's not really clear why we would instantiate the pipeline once with the class instead of for each test.