Ryan Mitchell

Results 264 comments of Ryan Mitchell

That’s probably enough - just wanted to know if it was worth spending time on or if there was a reason it wasn’t there already. If there’s anything approach wise...

I think this is good to go, but the tests are failing due to a segmentation fault (something on Github's side?)

Thats really helpful thank you. Ive got them all fixed now.

Same! No idea what’s going on.

@jasonvarga I cant figure this one out - everything passes locally using the same PHP and Laravel versions. The only thing I can notice thats different is the PHPunit version...

I've got all the tests passing by [specifying a min version of phpunit (8.5.23) on the PHP8 mockery action](https://github.com/statamic/cms/pull/6506/commits/9fe1aeaeed5bdab3c9349e0eb7f012fa0e8c8d11). Hope this is an acceptable solution.

You need to add that function to your App\Models\User file ``` public function id() { return $this->id; } ```

@edalzell what about using `@` instead of ::?

Ok. It seems handle is the consensus so I will change it to that!

Yeah that’s a good point. We could delete it after running, or we could leave that to the starter kit author?