Gyeongjae Choi

Results 674 comments of Gyeongjae Choi

`getaddrinfo` is not implemented in Pyodide as we don't support Socket. So `aiohttp` needs to be patched to support environment without socket.

Thanks! I am planning to move all packages from this repository to [`pyodide-recipes`](https://github.com/pyodide/pyodide-recipes) soon. Could you please open a PR there? Also, we don't accept a PR that only adds...

Closing as I unvendored recipes in this repository. Please open the same pull request in pyodide-recipes.

Looks like the output of the library has slightly changed, which is breaking the test. Could you please update it? Otherwise looks good to me.

Looks like it is quite tricky to make the tests work 😂. I think it is okay to remove some test cases that rely on too specific behavior of the...

> I think it is likely possible to cache, caching sound good to me.

@hyoinandout Assigned to you. Thanks!

@snghnl Sure. But note that we already have a runtime detection in JS side, which is used internally in Pyodide. @Drranny is working on the related issue (https://github.com/pyodide/pyodide/pull/5877). The additional...

@snghnl Thanks for the question. `pyodide_js._api` is a private API that we don't want users to use. It is not documented either. > It also seems that https://github.com/pyodide/pyodide/pull/5917 doesn't want...

> Maybe a function along the lines of assert_runtime(runtimes: Sequence[Literal['node', ...]]) ? Naming-wise, `assert` sounds like an assertion, so I would prefer something like `check_runtime`. Other than that, having a...