pyodide icon indicating copy to clipboard operation
pyodide copied to clipboard
verified publisher icon pyodide

Fix Brave bug with online REPL

Open agriyakhetarpal opened this issue 5 months ago • 4 comments

Description

Closes #5791; brings a new jquery.terminal version and updates the tests to match.

cc: @jcubic

Checklist

  • [x] Add / update tests

agriyakhetarpal avatar Jul 24 '25 19:07 agriyakhetarpal

I seem to have no issues with https://pyodide--5792.org.readthedocs.build/en/5792/console.html with Brave locally. I do have trouble and can reproduce the problem on https://pyodide.org/en/stable/console.html. Similarly, this problem also appears in the stable console on Arc Browser (which is based on Chromium Engine version 138.0.7204.158), and this PR fixes it. I'll leave this open for others to confirm. Thanks!

agriyakhetarpal avatar Jul 24 '25 20:07 agriyakhetarpal

Looks like the output of the library has slightly changed, which is breaking the test. Could you please update it? Otherwise looks good to me.

ryanking13 avatar Jul 27 '25 04:07 ryanking13

Thanks for the catch, @ryanking13! I've pushed the changes. It looks like we could rewrite the test as it is too specific, but I shall defer that for the next time we update jquery.terminal.

agriyakhetarpal avatar Jul 27 '25 20:07 agriyakhetarpal

Looks like it is quite tricky to make the tests work 😂.

I think it is okay to remove some test cases that rely on too specific behavior of the jQuery terminal.

For instance, if what we expect in the test case is that it shows "Pyodide has suffered a fatal error" message, checking that those values are correctly printed would be enough.

ryanking13 avatar Jul 30 '25 11:07 ryanking13