Ryan Baxter

Results 639 comments of Ryan Baxter

Can you provide a [complete, minimal, verifiable sample](https://stackoverflow.com/help/mcve) that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip...

The exception that should be thrown when the circuit breaker is open is `CallNotPermittedException`.

Sorry I am not following what you are saying

Did you follow the instructions here? https://docs.spring.io/spring-cloud-config/reference/server/aot-and-native-image-support.html cc: @OlgaMaciaszek

This would be a good enhancement for our next major release where we can introduce some breaking changes. We think it would be to explore introducing a "context object" so...

Personally I would prefer approach B, but I would remove the constructor and just use setters and getters.

I think we would want query and path parameters (name, profile, label, etc). And I agree it is a big changes, hence why it makes sense for a major release....

I would't remove `RequestContext` from this PR. What I would suggest is we introduce `RequestContext` and move the existing parameters to it in another PR and then in this PR...

Thanks for the PR! We are going to wait to merge this until we branch for our 2024 release train later this year. Once we branch we will get this...

I think this is the right idea for where we want to go. The issue is as is it could only go in a major release because of the breaking...