Ryan Baxter comments

Results 639 comments of


                                            Ryan Baxter

Include route map configuration so routes across property sources can be merged

Are you doing something like configuring routes in different configuration files and then enabling them via profiles? You can specify ids for routes using a gateway.

The file uploaded by the client in the mode of transfer encoding: chunked cannot be forwarded correctly by the gateway.

In `RemoveHopByHopHeadersFilter` you can actually set the list of headers removed using `spring.cloud.gateway.filter.remove-hop-by-hop.headers`. So my first question is if they modify this property to not remove transfer-encoding if it would...

More flexible path matching (such as file extensions and logical or)

Maybe we need something like an extension filter? The path filter probably doesnt take into account the file extension. @spencergibb thoughts?

Circuit Breaker doesn't support dynamic fallback URI in Java configuration

I created a route config like the following in a unit test ``` .route("fallback_with_segments", r -> r.path("/fallback/{segments}").filters(f -> f.setPath("/circuitbreakerFallbackController/{segments}")).uri(uri)) ``` and it worked. Can you try removing `*` in `{segments}`...

Circuit Breaker doesn't support dynamic fallback URI in Java configuration

Thanks I was able to reproduce this and have a PR with a fix. As a workaround I think you can do the following and it should work `UriComponentsBuilder.fromUriString("forward:/inCaseOfFailureUseThis/{segments}").build().toUri()`

@AutoConfigurationOrder doesn't seem to have any effect on the bootstrapping order anymore.

@spencergibb why did you reopen this? Is it a bug?

Add Support For Reactive Bulkheads

Sure PRs always welcome

Add Support For Reactive Bulkheads

Its hard for me to say for sure as to why it is there. Likely to exclude some classes related to micrometer to make sure we are not depending on...

Cannot resolve symbol for both RetryExceptionWrapper.class

This just happens when changing the JDK version? Could you provide a sample that reproduces the problem?

Cannot resolve symbol for both RetryExceptionWrapper.class

We are running out builds with JDK 17 and don't see that problem, so a project to reproduce the problem will help figure out what is going on.