ryanheise

Results 1670 comments of ryanheise

After testing this PR I'm getting: ``` /Volumes/Samsung_T5/projects/audio_service/audio_service/darwin/Classes /AudioServicePlugin.m:291:9: error: implicit declaration of function 'os' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (os(macOS)) { ``` Looks like this is a Swift...

I think this PR needs to use `#if TARGET_OS_OSX` instead of `if (os(macOS))` and it should also still keep the `@available` checks since it is still only available on specific...

> I tried to use the version by @pedromassango, but upon compiling I got the following errors: Yes, that is a problem with this PR, and I have mentioned in...

Yes I agree something should be done about that, but has anyone tested the changes @pedromassango proposed but using the `#if TARGET_OS_OSX` code instead? I am not sure if it...

Has anyone tried this solution and tested on both iOS and macOS?

Regarding the `os` error, see this commment: https://github.com/ryanheise/audio_service/pull/900#issuecomment-1031272743

This has been noticed before, and I would like to fix it. Can you describe in more detail how this supposed solution would work? In particular, you say: > which...

I don't understand your description of the difference between these two APIs. They seem equivalent to me. In particular, you say that the problem is that audio_service handles the audio...