ryanheise

Results 1670 comments of ryanheise

The fixes so far have now been published on pub.dev.

Since each player has its own proxy, I think that creating a new player would be a way for the app to recover after this error, although that's only a...

> macOS (and I assume iOS) make a HTTP request as soon as the source is added, even if it's not meant to be played yet. That behaviour can be...

Also regarding the fact that `prepareSource` is only called once, the reason I brought that up is that the name "lazy" actually makes more sense now than if it had...

Here is the other related issue/comment: https://github.com/ryanheise/just_audio/issues/294#issuecomment-1168174989 I like that naming of calling it a "childBuilder" or something of the sort, since it fits with Flutter's pattern of builders. But...

Interesting. I guess they both achieve the same result, but what a great name: `ResolvingAudioSource`.

So how about it - shall we agree on `ResolvingAudioSource` or would you prefer to keep the current name?

> I'm having a hard time understanding how to get the `tag `of the `AudioSource `generated by `MappingAudioSource`. Why do you say the tag is generated? I don't think this...

OK, so I don't think you explained how the tag was generated "by" `MappingAudioSource`. The tag is not generated by the plugin, it is supplied by you in the constructor....

Thanks for the report. The position could/should probably be clipped with `min(position, duration)` but only where the duration is actually known. I would also point out that the duration is...