Ryan Greenberg

Typechecker does not identify errors in unreachable code

2

**Describe the bug** Errors in code after a return statement are not identified. **Standalone code, or other way to reproduce the problem** ```Hack function unreachable_1(): int { return 5; return...

Falsy checks for empty vecs break type checker soundness

1

**Describe the bug** An empty `vec[]` does not pass a truthy check but it still a vec. The typechecker incorrectly infers that values in the other branch of this check...

Clarify that "Arrays" documentation includes vec, dict, and keyset

8

I fielded an internal question at Slack about how to append objects to `vec`s, and more generally where to find this information in the docs. I pointed to https://docs.hhvm.com/hack/built-in-types/arrays, which...

UnusedVariableLinter semi-incorrectly detects some loop variables as unused

3

Given the following code, `UnusedVariableLinter` flags the foreach loop variable `$apple` as unused and suggests an autofix to `$_apple`. This then causes a typechecker error because `$apple['number']` is using `$apple`...

Provide ability to specify percentile groups beyond quartiles

1

I think `st` is great and I use it all the time. One thing that would make it more useful for me is the ability to be more selective about...

Differentiate retries for NOT_OPEN and TIMED_OUT transport exceptions

9

The underlying `thrift` Ruby library raises `TransportException` under a variety of circumstances: From thrift's [socket.rb](https://github.com/apache/thrift/blob/master/lib/rb/lib/thrift/transport/socket.rb): ``` raise TransportException.new(TransportException::NOT_OPEN, "Connection timeout to #{@desc}") raise TransportException.new(TransportException::NOT_OPEN, "Could not connect to #{@desc}: #{e}")...

Cannot validate 'pattern' that contains a forward slash

1

Adding a `pattern` property to a schema is supposed to validate a value using the provided regular expression. This is done in generated code using `StringPatternConstraint`: ```Hack class StringPatternConstraint {...