Ryan Carsten Schmidt

Always links with libzstd static library instead of shared library

1

If zstd is found, the GLE build always links with the libzstd static library instead of the shared library: https://github.com/vlabella/GLE/blob/d770ed475aedeef6a59f653e5f31f1680deafaff/src/gle/CMakeLists.txt#L133-L140 https://github.com/vlabella/GLE/blob/d770ed475aedeef6a59f653e5f31f1680deafaff/src/gui/CMakeLists.txt#L97-L101 Users on Unix generally expect shared libraries to be...

Policy CMP0167 is not set: The FindBoost module is removed.

1

This message appears while building GLE 4.3.4: ``` CMake Warning (dev) at CMakeLists.txt:118 (find_package): Policy CMP0167 is not set: The FindBoost module is removed. Run "cmake --help-policy CMP0167" for policy...

Remove reserved identifiers

2

You define some identifiers that begin with a double underscore: https://github.com/vlabella/GLE/blob/97cf2ca024ef9a12abf6fe6024439faf0c82a0e8/src/CMakeLists.txt#L254-L259 https://github.com/vlabella/GLE/blob/97cf2ca024ef9a12abf6fe6024439faf0c82a0e8/src/CMakeLists.txt#L299-L303 https://github.com/vlabella/GLE/blob/97cf2ca024ef9a12abf6fe6024439faf0c82a0e8/src/CMakeLists.txt#L342-L346 Identifiers that begin with a double underscore are reserved for the exclusive use of the compiler. You...

Provide a way to specify where libgs is

2

You look for libgs in a variety of locations varying depending on the OS: https://github.com/vlabella/GLE/blob/97cf2ca024ef9a12abf6fe6024439faf0c82a0e8/src/gui/qgslibloader.cpp#L295-L310 but on any OS those locations are not necessarily where libgs is actually located. Please...

Things are installed directly into $PREFIX rather than appropriate subdirectories

1

GLE 4.3.4 installs these documentation files: ``` $PREFIX/doc/ChangeLog.txt $PREFIX/doc/README.txt $PREFIX/doc/LICENSE.txt ``` `$PREFIX/doc` is the wrong place to install such files. They need to go into a standard directory (`$PREFIX/doc` is...

Building without Qt

2

Running `cmake` for GLE 4.3.4 fails with this message: ``` CMake Error at gui/CMakeLists.txt:10 (find_package): By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package...

When compiling GLE 4.3.4 with clang this warning appears: ``` src/gle/tex.cpp:1569:31: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] if (c < 0 ||...

`-O` is already specified in the default CFLAGS. Do not override other optimization flags the user might have specified in CFLAGS.

Only include the local macOS 11 SDK copy of vecLib.h when using the macOS 12 SDK or later to prevent build failure when using the OS X 10.9 SDK or...

#9 (the fix for #8) broke the build when using the 10.9 SDK and older. You now unconditionally include a copy of vecLib.h that came from the macOS 11 SDK,...