Ryan Carsten Schmidt

Correctly detect if linker supports noexecstack

3

When testing for support of multiple flags, the flags must be separated by semicolons not spaces. See https://gitlab.kitware.com/cmake/cmake/-/issues/26024 When referenced elsewhere, enclose the flag variable in quotation marks so that...

malloc.c:22:87: error: use of undeclared identifier 'MAP_ANONYMOUS'

5

ngs fails to build on OS X 10.10 and earlier. ``` malloc.c:22:87: error: use of undeclared identifier 'MAP_ANONYMOUS' ``` Here's a recent build log: https://build.macports.org/builders/ports-10.10_x86_64-builder/builds/274533/steps/install-port/logs/stdio On older macOS and BSD,...

Remove /usr/local and /opt/homebrew

4

This code is wrong, or at least partly unnecessary and partly inconvenient: https://github.com/ngs-lang/ngs/blob/dd1bc7021e7315878613e20e6393b1c33f3925c3/CMakeLists.txt#L24-L25 /usr/local does not need to be mentioned here because compilers look in /usr/local by default. /opt/homebrew should...

Documentation belongs in share/doc

1

This code is wrong: https://github.com/ngs-lang/ngs/blob/dd1bc7021e7315878613e20e6393b1c33f3925c3/CMakeLists.txt#L130 Documentation belongs in share/doc, not doc.

Manpages should go in share/man

2

This code is wrong: https://github.com/ngs-lang/ngs/blob/dd1bc7021e7315878613e20e6393b1c33f3925c3/CMakeLists.txt#L132-L136 As far as I know, manpages belong in share/man on all platforms of this millennium, not just Apple platforms. See the [FHS](https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s11.html#usrsharemanManualPages). See #503.

malloc.c:71:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]

2

Building ngs 0.2.16 I see this warning: ``` malloc.c:71:1: warning: non-void function does not return a value in all control paths [-Wreturn-type] } ^ 1 warning generated. ```

Fixes the following issue reported in #8: ``` error: implicit declaration of function 'fft_krn' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ``` And the additional errors I saw: ``` error: implicitly declaring...

ChangeLog has no entry for release 0.4.0 and it has typos: ```diff --- CHANGELOG.md.orig 2021-11-14 02:48:00.000000000 -0600 +++ CHANGELOG.md 2024-07-02 15:22:11.000000000 -0500 @@ -1,6 +1,6 @@ ## 0.3.0 -The CLI...

stack_not_16_byte_aligned_error on macOS Catalina

3

Hi, [raceintospace in MacPorts](https://ports.macports.org/port/raceintospace) (latest code from 2020-06-03, 8ff7814, plus the fix from #363) builds and runs on macOS Catalina 10.15.5. After fixing [the libsdl bug](https://bugzilla.libsdl.org/show_bug.cgi?id=4788) the window contents are...

Could not find a package configuration file provided by "JBIG"

3

When running `cmake` for GLE 4.3.4 this message appears: ``` CMake Warning at CMakeLists.txt:123 (find_package): By not providing "FindJBIG.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package...