Ryan Brandenburg
Ryan Brandenburg
Killing this PR as the Surface Area seems to be mostly nailed down. If you still have feedback feel free to take it to https://github.com/dotnet/roslyn/pull/62924.
Policy will probably dictate that this package begin with a reserved prefix like `Microsoft.`
> Aka, if protocol changes does that mean we need to release anew CLaSP? Can it be decoupled? Does it matter? If all the protocol changes is the inclusion of...
> I see, it definitely feels odd to have a dependency on the protocol types purely for a base "InitializeParams" object. I imagine the next step would be someone who...
Lots of updates, equivalent for the surface area PR coming soon.
> Is there anything in particular we should be looking at? GitHub breaks when I try to get it to show me commits since my last review... It's hard to...
@333fred I'm removing the "Needs API review" tag after our previous conversation about putting this on a non-public feed for now. Let me know if that's not appropriate.
The problem with the solution that was used for #1603 is that when you pass in the LogFileName you have no way of knowing what name the resulting file will...
Not for the EF6 Designer AFAIK. If you have a technique I'd love to hear it.
Requesting re-reviews. In my struggle to get unit tests to work I ended up writing some Integration tests instead. The single-server Unit tests for this area get a bit weird...