Ryan Avella

Results 40 comments of Ryan Avella

Interestingly with just one small change, the string splits at slightly different boundaries. ```diff - let html_string = r#""ABC">DE"#; + let html_string = r#"ABC">DE"#; ``` Output: ``` CharacterTokens(Tendril(inline: "ABC")) CharacterTokens(Tendril(inline:...

I think I see why this is happening. When processing named entities in `do_named`, the first character of the `BufferQueue` is eagerly removed (rather than peeked at) and then appended...

I'm generally in agreement RE: correctness. To me this is more of a performance concern. I see two potential sources of overhead: * In `html5ever` itself, some bytes are unnecessarily...

@P-E-Meunier by "emulate," do you mean a call that avoids unnecessary truncating? i.e. something like this? ```rust #[cfg(target_os = "freebsd")] pub fn allocate(file: &File, len: u64) -> Result { let...

@rtyler I'm not sure if fs2 is maintained any more, the last commit was >5 years ago and several important PR's have been left open for nearly as long. You...

I think the reason FreeBSD returns `EINVAL` with `posix_fallocate` is that fallocate doesn't really make much sense on a copy-on-write filesystem. My workaround is to match on `fs4::allocate` and ignore...

@Toasterson see my comment [here](https://github.com/danburkert/fs2-rs/issues/25#issuecomment-1472652028), tl;dr: I think you may have an easier time upstreaming patches to fs4 than to fs2.

Could this `uid` workaround method be added to the `jail::Jailed` trait? It's a breaking change, but I don't think would present much friction to downstream users, especially if we gave...

> From my testing it seems like the following need to be in place for it to happen: > * Windows 11 (I can't seem to get it to happen...

I can confirm that the problem is reproducible with Terminal (v1.17), but it goes away with Terminal Preview (v1.18). @konnorandrews suggestion for a slight delay on Windows makes the most...