Ryan Wolbeck

Results 26 comments of Ryan Wolbeck

Hey @alejandroschuler, Yeah I think to the casual user the documentation and just he user guide is sufficient but if you'd like to look at say what the base default...

@rotcx can you share your code?

@alejandroschuler I've been thinking about this some more and I'm thinking about adding in pre-commit hooks to setup a lot of the formatting related stuff. I'm also a fan of...

@soumyasahu can you take a look at fixing the following ************* Module ngboost.distns.mixture_normal ngboost/distns/mixture_normal.py:3:0: C0414: Import alias does not rename original package (useless-import-alias) ngboost/distns/mixture_normal.py:50:57: E0602: Undefined variable 'mixprop' (undefined-variable) ngboost/distns/mixture_normal.py:55:78:...

@guyko81 in order to get the build to function properly you'll have to modify https://github.com/stanfordmlgroup/ngboost/blob/master/pyproject.toml instead of the requirements.txt

Updated link to the dev guide https://stanfordmlgroup.github.io/ngboost/5-dev.html

> hey @wakamezake I've started to expand the test suite a bit and I'm wondering if you're interested in lending a hand. Ideally I'd like to test all the combinations...

@alejandroschuler I really like the idea of doing your first suggestion, it would then follow [PEP 8](https://pep8.org/#descriptive-naming-styles). I don't really have an opinion on the second piece.

@alejandroschuler yeah I can do this, not sure when I'll get to it but I'll put it on the backlog

@jckkvs It's still failing, I tried to push but I'd need permissions on the fork you have. You'll still need to run black for this to pass so, `black ngboost/ngboost.py`...