Bryan Elee

Results 20 comments of Bryan Elee

> I can try to implement a sightly better version and link it here. ok, looking forward to it

> We can also use filesystem module from c++ 17 but I don't like it, it's very heavy. The portability path are just few small C functions with size safety....

I have chosen to just add support for sub folders in plugin_extension https://github.com/metacall/core/pull/306

created this flowchart for the cli-refactor project ![cli-refactor-program-flow](https://user-images.githubusercontent.com/33056740/164227494-84fb5aed-b078-401b-a3e5-33fafd12c7db.png)

@vindard, I will like to work on this issue. Can I get assigned to it.

> Check out the tests, no one is passing, try to pass them before pushing. I just figured out what's making the tests fail. I would fix it as soon...

> Also there's this in windows: > > But I think this has been already solved in develop, can you merge develop into your branch and push so we can...

> I node port it seems there's a bug: > > 2023-02-21T01:41:33.6835696Z attempt to reference unallocated memory (signal SIGSEGV) That's not the only problem. There's alot of load_from_file errors... look...

I have been reviewing this attached file [output-node-segfault.txt](https://github.com/metacall/core/files/9561142/output-node-segfault.txt) and I can see that metacall-callback-complex-test fails here ``` (/usr/local/metacall/build/node_modules/acorn/dist/acorn.js:817:23) at Espree.parseTopLevel (/usr/local/metacall/build/node_modules/espree/dist/espree.cjs:663:26) at Espree.parse (/usr/local/metacall/build/node_modules/acorn/dist/acorn.js:589:17) at Espree.parse (/usr/local/metacall/build/node_modules/espree/dist/espree.cjs:585:35) { index: 8,...

`espree` won't parse function calls written this way ```js function(x) { }; ```