rx-dwoodward

Results 18 comments of rx-dwoodward

This PR is ready for reviewing, please let me know if there are any other steps I can help out with here! Please review :)

@PrettyWood is there anything else I need to do on my end on this PR? This is my first PR into pydantic so apologies if I've missed an automation somewhere!

Thanks @sydney-runkle for looking through it! hmm weird, running locally all my tests pass, though perhaps I should exclude the mypy module from being imported directly in the import test,...

oh actually nevermind the `__getattr__` can be pretty simple: ``` import pydantic def __getattr__(name: str) -> Any: return getattr(pydantic, name) ``` seems to do the trick.

I'm not entirely sure there is a nice fix for the linux compiled tests to be honest - not one that I can think of at least :( (that doesn't...

@sydney-runkle any ideas on why the Windows builds _fail_ with seemingly no error? 🤔

Looking at the commit log - I believe that the tests on `windows` passed previously before the `ci.yml` [was changed](https://github.com/pydantic/pydantic/pull/9162/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f) - could this be the issue? For example [here](https://github.com/pydantic/pydantic/pull/9162/checks?check_run_id=24442481389) the...

not too sure what changes need to be made to `ci.yml` - is there a commit on `main` you could point me towards? Also I'm happy to revert the absolute...

> @exs-dwoodward, > > Try using the `ci.yml` file from `main` so that there's no diff I believe thats what I've done here (the diff comes from the fact this...

I would but I'm afraid that doing so might cause the [linux-compiled tests](https://github.com/pydantic/pydantic/pull/9162/checks?check_run_id=24690796602) to fail 😅 whereas swapping the relative --> absolute imports [causes all the tests to pass](https://github.com/pydantic/pydantic/pull/9162/checks?check_run_id=24772406344) (apart...