Rob Buis

Results 26 comments of Rob Buis

I removed some unneeded things from the patch, it is now a straightforward "introduce runtime flag and start parsing" patch. PTAL.

The patch now looks good to me!

> Consider importing WPT, new tests have been added during the implementation in Gecko. Good idea, working on that here https://bugs.webkit.org/show_bug.cgi?id=245271.

Closing this, Claudio is continuing in https://github.com/WebKit/WebKit/pull/27194.

@nikolaszimmermann this is more a discussion start right now rather than a review request, since there may be some relationship with https://github.com/WebKit/WebKit/pull/25118. I actually wonder if it does not make...

Also, one problem with this patch as-is is that it causes some extra repaints on some tests.

> Also, one problem with this patch as-is is that it causes some extra repaints on some tests. This is now fixed. This is done by replicating some code at...

This will be hopefully not be needed if https://github.com/WebKit/WebKit/pull/25247 can land. Will close this should that one land.

Closing because this is addressed by https://bugs.webkit.org/show_bug.cgi?id=270240.

I think this fixes the DRT output : diff --git a/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp b/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp index 995f6624fd2b..c3f04aeb266a 100644 --- a/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp +++ b/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp @@ -527,8 +527,8 @@ void writeSVGResourceContainer(TextStream& ts, const LegacyRenderSVGResourceCont void writeSVGContainer(TextStream&...