Rob Buis

Results 26 comments of Rob Buis

> So after discussing with fantasai, the css-sizing-4 transferred min/max size text should not apply in flexbox/grid. Instead, only the sizing inside those specs should apply. For flex: > >...

Ah, never mind, I see those tests got corrected.

> Alignment would only require changing the tests, right? @rwlbuis do you want to create a PR for that? Sure, I created a PR here https://github.com/web-platform-tests/wpt/pull/35750.

The WPT change has landed and I am importing the latest changes in https://bugs.webkit.org/show_bug.cgi?id=244679, so closing this issue. Thanks!

> Great! > > Reopening for the spec clarification. Sorry! I forgot there was more to do.

Note that the patch has been reduced a lot and now has only the basics and should be easier to review. The plan is to file bugs like https://bugs.webkit.org/show_bug.cgi?id=245775 for...

This system gets confused about multiple people working on a PR, and git-webkit was not able to make me owner of this PR. So I will use good old bugzilla.

> PTAL( finally all green again!). Ok, I was wrong before, only today this became green :}