Robert Jackson comments

Results 989 comments of


                                            Robert Jackson

make @glimmer/compiler runable in browser

Hmmm, I don't think this should be needed. It is definitely possible to use `@glimmer/compiler` in the browser without hitting this `require('crypto')` code (all of Ember's own tests do this...

make @glimmer/compiler runable in browser

@izelnakri - Thanks for your response! I totally agree with you, I'd like to see progress on that front (help absolutely welcome!!). Specifically, I'd like to: * Change our build...

Preprocessing into AST doesn't work with <!DOCTYPE> tags

FWIW, https://github.com/tildeio/simple-html-tokenizer/pull/71 is working on fixing this.

`undefined`, `true`, `false`, `null` property names in context does not work

I think these will have to be fixed in @handlebars/parser. For now you can work around via `(get this 'undefined')`.

Published package.json broken for @glimmer/interfaces

Ya the `types` entry point seems wrong there (I think it should be `dist/types/index.d.ts`).

ability to print to html

What does this do? How is this different from the existing printer? Do we really need to duplicate all of the code?

Missing dependencies when relying on @glimmer/syntax

Confirm. `@glimmer/interfaces` really should have no non-type dependencies

Missing dependencies when relying on @glimmer/syntax

@thorn0 yes

Investigate test failures with @handlebars/[email protected]

https://github.com/glimmerjs/glimmer-vm/pull/1285 pins to @handlebars/[email protected] while we debug those two tests.

Expected call head to be a string, got [32,0,["resetEditedItem"]]

Is this still an issue with ember-source's canary channel?