Rob Winch

Results 236 comments of Rob Winch

I think an outline would be: ## Allow Injecting the Principal Name into `DefaultOAuth2User` Right now `OAuth2UserService` requires defining the `name` property as an attribute name. This limits the flexibility...

Thanks for reaching out and your patience as we put the final touches on this @yybmion > Deprecating the nameAttributeKey field in DefaultOAuth2User constructors for consistency with the new usernameExpression...

Thanks again for all of your work on this PR! I'd like to encapsulate the logic (keep private) in `OAuth2UsernameExpressionUtils` so that we can refactor without breaking anything later. One...

Hello! You will probably need to coordinate with @jimmyjames as I'm not a commiter on this project.

@oehme Thank you for the response. From my perspective build scans are not ideal * Build scans require addtional setup (required email is not very user friendly for such a...

Thanks for the PR! I've rebased on the current main and this will be merged as soon as the build passes. Thanks again for taking the time to make Spring...

Thanks for the response @sbrannen Yes. I was imagining Spring Framework would provide a `WebTestClientConfigurer` implementation that allowed replacing the `SslInfo`. However, I didn't want to be prescriptive on how...

Thanks! This does work. Given it's a pojo I wonder if you could expose an implementation of SslInfo so that a mock is not needed?

@sbrannen @rstoyanchev Thank you for the work here. I'd like to use `SslInfo` testing support to test different `SslInfo` scenarios, but I'm running into some difficulty because the `SslInfo` must...