Rob Winch

Results 236 comments of Rob Winch

@wilkinsona Thanks for reaching out. We are currently planning on adding support for finding by username for 2.1. For tracking I created https://github.com/spring-projects/spring-session/issues/914

> Regarding enableIndexingAndEvents, we'll hold off on that for now until you've had a chance to discuss things with Rob. I'd avoid adding this property since we are leaning against...

> Does this mean that you're considering reverting the introduction of the attribute? Sorry this was not very clear. What I meant is that, I'd avoid adding the property to...

I don't think many applications are actually needing externalized configuration for theses properties. If they do, I don't view this as a large amount of code. Users can reuse Spring...

@wilkinsona Perhaps I am missing something, but I haven't seen any improvements with this from a Spring Security standpoint. For example: ``` spring: security: oauth2: client: registration: github: | ```...

Thanks for the clarification @snicoll. I wasn't aware that .properties were supported by IntelliJ. Also glad to hear that this means this is a higher priority. I had misunderstood it...

Thanks @kdvolder! I will have to give it a try in the latest STS. PS: The dependency you need is org.springframework.boot:spring-boot-starter-oauth2-client

I do not believe this is anything to do with Spring Security. Spring Security wraps the `HttpServletRequest` but only `DummyRequest` implements `HttpServletRequest.getRequestURI()`and it doesn't appear to be used in the...

Thanks for the reply @MartinHaeusler Looking at the `removeSemicolonContent(String)` and `removeJsessionId(String)` along with Eclipse Adoptium 17.0.3 source I'm not understanding how it would be possible for them to return a...

Thanks for bringing this to my attention @sbrannen. It does appear that the class generated by CGLIB is (indirectly) holding a reference to `MethodSecurityMetadataSourceAdvisor` which in turn holds a reference...