Ralf W. Grosse-Kunstleve
Ralf W. Grosse-Kunstleve
> I'll look into how easy it is to split them apart after work. Give me a moment, I'm trying to do that with cursor right now. I'm hoping that...
I just created PR #5891 to isolate out the `typing.SupportsIndex` fixes. @InvincibleRMC @gentlegiantJGC When you see that the tests are passing, could you please review? Please approve formally if the...
That's much easier to review now! The production code changes are actually very easy to review now. I'll comb through the test changes carefully tomorrow, for a final confirmation that...
xref regarding merge & release planning: https://github.com/pybind/pybind11/pull/5887#issuecomment-3518889816
I've been working through the PR to understand the behavior changes and ensure everything is correct. Sorry it took me way longer than I'd want to admit to realize that...
FYI — While I was at it, I isolated out this change, to be merged asap: * https://github.com/rwgk/pybind11/commit/89917e9264dc8839fab16afda0f0d7ae24ffda0d I'll mark you a co-authors there. (I should have done that yesterday...
The extra tests (commit f1d81588b9b3dfb78111a23cd1853841394a29f2) are: * To be certain about the exact behavior in pathological cases, so we're sure we don't have silent float to int conversions. * To...
BTW, having looked at this so intensely ... ```C++ bool py_err = py_value == (py_type) -1 && PyErr_Occurred(); ``` this will be OK if Python is healthy, but if something...
> I can't see any obvious issues Same. I looked through everything several times now. Thanks!
@gentlegiantJGC @timohl @InvincibleRMC for visibility