Ralf W. Grosse-Kunstleve
Ralf W. Grosse-Kunstleve
This is a first **completely untested** approximation to what the **small** (almost tiny) cpython change would look like: https://github.com/rwgk/cpython/commit/52a03ff27415d028c6982ac5e25958e43c8eb8e6 Anyone with cpython development experience seeing this: It'd be awesome if...
> The first step for this sort of thing is to bring it to the #ideas category on discuss.python.org. Active help would be highly appreciated. I changed the title of...
@cyyever WDYT about changing our clang-tidy job to run with `PYBIND11_HAS_SUBINTERPRETER_SUPPORT`? Our CI resources are very limited, therefore just one job is probably most practical.
> For limited resources, running tidy and fixing errors periodically is enough. There is no need to modify current jobs. Hm, according to a quick analysis done with Cursor, we'll...
Thanks for doing this cleanup and for running clang-tidy over the subinterpreter code paths - having those headers/tests tidied is definitely appreciated. That said, we generally try to avoid one-off...
> @rwgk `PyObject_HasAttrString` ignores errors That's exactly what we want here. The code changed is handling errors. We don't want to handle any non-critical secondary errors during the handling of...
Hi @swolchok I used Cursor to review this PR. It generated the four added commits, which are all of the relatively minor and polishing kind: * 279c72a04f6cb3062ee862713005c4f37d4d47f3 Add static assertion...
> > Could you please review my commits and the new sections in the PR description? > > LGTM Thanks! I think this is ready for merging, but ... wrt...
I'm not a big fan of the global macro. If we want to test it, we have to [make many adjustment to the unit tests](https://github.com/pybind/pybind11/pull/5875#issuecomment-3419231485). I see that as an...
Responding to https://github.com/pybind/pybind11/pull/5875#issuecomment-3423089099 here (to keep the discussions in one place): > I will try to make a single test that uses this macro instead of the other change -...