Richard West

Results 233 comments of Richard West

I think #2277 (which supersedes this) is now part of #2316. Hopefully that is merged soon.

I rebased, did a few interactive rebases to clean up some fixups and merge conflict markers that had gotten in there, and force pushed.

The database tests are failing, because some sample molecules are being made that are charged. ```Kinetics family 1,2_Insertion_CO: Entry is accessible? ... ERROR:root: In family 1,2_Insertion_CO, a sample molecule made...

Did this get stalled? I'm trying to interpret the comments above. Is someone resolving conflicts?

@mjohnson541 do you have any example input files for electrochemistry that you could include here? @JacksonBurns what's the status with https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2598 ? do we rebase that onto this, and then...

From the penultimate comment above this issue spawned 3 PRs that have all been merged, and is now resolved.

I think this would address https://github.com/ReactionMechanismGenerator/RMG-Py/issues/1748

I think this is now part of https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2316 which has been more recently rebased and checked. Hopefully that will be merged soon.

I rebased this and https://github.com/ReactionMechanismGenerator/RMG-database/pull/416 There's discussion on there between @cgrambow and @amarkpayne. But I see it was referenced by https://github.com/ReactionMechanismGenerator/RMG-database/pull/421 which says it depends on https://github.com/ReactionMechanismGenerator/RMG-database/pull/416 and also https://github.com/ReactionMechanismGenerator/RMG-database/pull/418...

@mjohnson541 this is how we generated labeled adjacency lists of transition states in order to give to tools like pynta, back in the day. Is this still a helpful way...