RMG-Py icon indicating copy to clipboard operation
RMG-Py copied to clipboard

Update atom enthalpies

Open cgrambow opened this issue 4 years ago • 1 comments

Corresponds to ReactionMechanismGenerator/RMG-database#416. Fixes unit tests that are affected by the updated enthalpies.

cgrambow avatar May 19 '20 22:05 cgrambow

Codecov Report

Merging #1955 (2a16b73) into main (215eb1b) will decrease coverage by 1.37%. The diff coverage is n/a.

:exclamation: Current head 2a16b73 differs from pull request most recent head ada3bd8. Consider uploading reports for the commit ada3bd8 to get more accurate results

@@            Coverage Diff             @@
##             main    #1955      +/-   ##
==========================================
- Coverage   48.57%   47.20%   -1.37%     
==========================================
  Files         110      104       -6     
  Lines       30812    27706    -3106     
  Branches     8054     7133     -921     
==========================================
- Hits        14968    13080    -1888     
+ Misses      14320    13220    -1100     
+ Partials     1524     1406     -118     

see 60 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 18 '21 18:10 codecov[bot]

This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days.

github-actions[bot] avatar Jun 21 '23 22:06 github-actions[bot]

Just commenting here to keep this alive for a bit longer. We'll probably want this in for the BAC paper @oscarwumit , but if I remember correctly this needed to wait for some other stuff to get in.

amarkpayne avatar Jun 22 '23 00:06 amarkpayne

Changing base to main to see how out of date this is.

JacksonBurns avatar Jun 22 '23 13:06 JacksonBurns

The only file in conflict is the CI.yml. I'm going to resolve this, and then it needs a look over @oscarwumit @cgrambow @amarkpayne

JacksonBurns avatar Jun 22 '23 13:06 JacksonBurns

I rebased this and https://github.com/ReactionMechanismGenerator/RMG-database/pull/416

There's discussion on there between @cgrambow and @amarkpayne. But I see it was referenced by https://github.com/ReactionMechanismGenerator/RMG-database/pull/421 which says it depends on https://github.com/ReactionMechanismGenerator/RMG-database/pull/416 and also https://github.com/ReactionMechanismGenerator/RMG-database/pull/418 Then that was mentioned by https://github.com/ReactionMechanismGenerator/RMG-database/pull/603

I'm now rather confused - does @alongd (who wrote https://github.com/ReactionMechanismGenerator/RMG-database/pull/603 which seems to be one of the most recent) know what's going on? Which of these should be merged and which should be closed without merging?

rwest avatar Jul 15 '23 19:07 rwest

This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days.

github-actions[bot] avatar Oct 14 '23 08:10 github-actions[bot]