Ross Blair

So we probably want to have the short_channel thing be a warning instead of an error. As of right now there is now good way to indicate that using just...

@rob-luke regex looks good, tested it out with a dataset with nirs with session and seemed to work. Updated the regex to match style of other rules that can match...

I believe this is ready. I'm going to let it sit for another day pending changes in the specification PR.

@sappelhoff try with that latest commit. Silly issue in the regex that covers coordsystem suffix.

Thanks @nellh I'll add that to my review. I did a fresh clone and install and couldn't recreate, figure its good to leave a trace of this fix somewhere since...

Regardless of if the validator is run via browser or node we create a dictionary with all the files as keys in the `fileArrayToObject` function in `utils/files/readDir.js`. Filenames could be...

@VisLab @happy5214 This looks great. Node test errors will need to be resolved which should happen with hed validator release, but conceptually I think its solid.

From meeting today, can at least issue error after this step in validation if an unacceptable modality is found: https://github.com/bids-standard/bids-validator/blob/c1c961599b086fdacf61cbc2327b35e8002f9bc3/bids-validator/validators/bids/fullTest.js#L46

added in #1418 but I realize now is still bypassable by bidsignore, ignored files are filtered out before the collectModality call is made inside of collectSummary.

Files in .bidsignore are getting culled even earlier that fullTest it looks like, printing length of Object.keys(fileList) does not change before or after collectSummary call, or even after a further...