Ross Blair
Ross Blair
For associations we'll need to add something like this to the schema: https://github.com/bids-standard/bids-specification/issues/1047#issuecomment-1086654227 Reviewing the associations they only ones directly accessed are expecting json/tsv. But the associated json/tsv can have...
Should be. It's published it on npm. Don't have time at the moment ~~but I'll make a PR for the validator to try and use it next week.~~
So we recommend both SI and the stricter CMIXF. But neither are required. But what is required is to have a units entry in a sidecar if the units are...
@sjeung you were very close, couple of naming issues and the filename regex started working. For the json, the schema had to be called in bids-validator/validators/json/json.js, I went ahead and...
@sjeung I went ahead and did the rebase with master, I can churn through them pretty quick (even though I made a couple mistakes). I'll review the validator and examples...
@sjeung Sorry for dropping this! I've reread the current specification PR and updated the validator as best I could. Few things I noticed: - ~~ExternalSoftwareVersions is present in the validator...
gah! Sorry about that, should always test again no matter how small the change is. Should be fixed in latest commit.
My apologies for the delay in response. So pet_blood specifies 'requires_tsv_non_custom_columns' key/value for which tsv columns are required in its json schema spec: https://github.com/bids-standard/bids-validator/blob/master/bids-validator/validators/json/schemas/pet_blood.json#L1 Here is the location in the...
I added a new property to the json schema 'required_if_tsv_value_present': https://github.com/bids-standard/bids-validator/blob/2b22d9884bdfca21d166abd1ec5442381b8ccd72/bids-validator/validators/json/schemas/nirs.json#L92 Specifies which column in the tsv to check against and which value should be present once. The I added...
First batch of work committed last week or so left short_channel requirement out. The spec makes it seem as if it is always optional or recommended not required: "If the...