Radek Vykydal
Radek Vykydal
/kickstart-test --testtype smoke
@t-feng thank you for the patch, it is greatly appreciated! We will review it as soon as possible. Also I am going to run our kickstart tests on it extensively...
The PR looks good to me. Based on suggestions by Thomas Haller in a recent issue: https://bugzilla.redhat.com/show_bug.cgi?id=2100883#c11 I'd also like to get rid of the sync Queue completely (its purpose...
For the record, I tested the original PR applied on rhel-9 branch - run 4422 tests with patched and un-patched anaconda. Without the patch there were 6 cases of segfault,...
/kickstart-test --testtype smoke
There are some issues caught by pylint in our validation tests (https://github.com/rhinstaller/anaconda/runs/7502614984?check_suite_focus=true) (It should be possible to run the tests locally as described here: https://github.com/rhinstaller/anaconda/tree/master/tests#testing-anaconda) ``` ************* Module pyanaconda.modules.network.nm_client W0703(broad-except):/tmp/anaconda/pyanaconda/modules/network/nm_client.py:590,15:...
Other than the remarks above the patch looks good to me and I think it is ready for merging. Thank you a lot for picking this issue up and fixing...
@t-feng hello, do you think you will be able to work on the PR in close future? I would like to finish it before forgetting what it was all about...
> > @t-feng hello, do you think you will be able to work on the PR in close future? I would like to finish it before forgetting what it was...
/kickstart-test --testtype smoke