Rick Viscomi

Results 431 comments of Rick Viscomi

Sorry, hard to debug when the JS is minified. Is there a jsfiddle or similar that you could post?

Strange. Could you provide a link to an example of this not working?

@simonferndriger could you make a sample page that demonstrates the problem? You can take out any confidential code or information. I just need a way to reproduce the bug you're...

See http://jsfiddle.net/BVFPv/3/ You're attempting to trunk8 all `div` elements, even the ones that are just wrappers. The key is to separate out the UI from the text. So I added...

@niemyjski thanks for filing this issue. innerHeight() may include padding, but there is no padding on the wrapper element. It's possible that the padding/margin of the truncated element is affecting...

A different approach could be separating the content (to be truncated) from the layout. So instead of your markup looking like this: ``` html Lorem ipsum ``` You may want...

However the padding/margin styles are being applied, whether by tag name or class name, my suggestion was to separate the element being styled from the element being truncated. I added...

@niemyjski I've marked this as a bug and queued it for fixing. Original thoughts on bug: > It's possible that the padding/margin of the truncated element is affecting the line...

Wondering about the performance hits this may incur. The current method to find the best truncation is a modified binary search. So at worst, the search takes O(lg(n)). The way...

Yeah, I agree it'd be better to make this opt-in. Curious if it can be made just as fast as the default functionality.