Rohan Vanheusden

Results 7 comments of Rohan Vanheusden

It seems that my implementation fails the `xlsx_richtext_namespaced` test; I'll try to look into this soon and hopefully add a test for merged cells as well.

Thanks for taking a look into this @Fuzen-py. I think that the issue here was my usage of subscripting for reading/writing `Range` cells. I updated the write method so that...

Right, but that's what I'm actually suggesting could be an issue. The test *implicitly* relies on merged cells working properly after this PR, whereas ideally the test will fail/succeed regardless...

Yeah, it seems that `-1, 0` shouldn't be matching any intervals that start with `0`. I don't actually have a use-case for negative numbers; I'm using NCLS for biological purposes,...

Huh, I guess maybe I should be using `first_overlap_both` and then just checking for results in the interest of speed. Although, that doesn't lend itself too well to readability.

Have you confirmed that building the interval tree is the main contributor for startup time? If so, it's perhaps worth taking a look at whether a majority of the time...

I don't know if `pysam` was ever an actual requirement. It was added in 1e7ea1e along with Biopython, but I don't think it's needed.