Robert Valek

Results 11 comments of Robert Valek

Hi, @samuell and @EvgSkv My team and I also looked into DatabricksSQL support, and we're doing some work right now to target Databricks at least partially. Some of it might...

Hi! We are a little behind on this promise due to some unrelated technical issues, but we are close to resolving them. Just wanted update here that we are still...

Hi @samuell , we merged the [baseline databricks dialect](https://github.com/EvgSkv/logica/pull/284) a couple of weeks ago. Feel free to try it out!

Yes, we could make `[]` compile to arrays by default, and only compile to `()` when used with `in`. Please let me know your thoughts.

Hi Max! Thank you! Here are simple examples of what I tried before making this PR. All of them fail with `unexpected array of values (not supported here)`: 1. We...

Hi guys! I think compiling existing `[]` arrays to SQL arrays by default and to `()` only for `IN` is the best approach. I updated the PR -- removing the...

@max-sixty @snth what are your thoughts on the updated version? The main caveat I see is that in `std.prql`, the `array` type is used to describe inputs to many functions...

Thank you, @snth! I forgot to check this case. With my changes, `from [{a=1}, {a=2}]` compiles to: ``` WITH table_0 AS ( SELECT 1 AS a UNION ALL SELECT 2...

Of course. The tests are failing because one of the negative test-cases is no longer returning an error: https://github.com/rvalek/prql/blob/0390bc2e4c4dc649ee1719b9eabd85f811bc7444/prqlc/prqlc/tests/integration/error_messages.rs#L107 That PRQL is now valid and compiles to: ``` SELECT [first_name,...

@max-sixty @snth we are all green now -- updated a couple tests and added one. Please let me know what else is needed.