Ruud Kamphuis

Results 363 comments of Ruud Kamphuis

I read the issue https://github.com/temporalio/sdk-php/pull/359 but saw some follow up PR's, one that introduced a global rejection handler: https://github.com/reactphp/promise?tab=readme-ov-file#set_rejection_handler Isn't this what was missing?

Should there be a new issue to track this? I'm a bit surprised that the Temporal SDK has deprecations on PHP 8.4, which was released 6 months ago.

Sure, but in this case, this SDK prevents installation of the latest major, so I think it would have been good if this project created that issue upstream. How else...

Maybe a solution could be to depend on https://github.com/php-http/discovery instead. This will still give a good developer experience, as it auto discovers a proper PSR client. I said it before,...

> but I would still like to provide a default client so that users can use the library without needing to install an additional HTTP client I get that this...

Next to that, you could add a [suggest](https://getcomposer.org/doc/04-schema.md#suggest) to the composer.json file, that guzzle can be used as PSR-18 client.

I agree that the docs are very hard and overwhelming. I feel kind of dumb not understanding anything of it. If you have ideas on how to improve the docs,...

Came here to report the same problem. I have a dev dependency that needs some attributes declared in `src` here and there for developer purposes. They don't harm nor affect...

Yes, I just ran some testing. With final entities and `enable_native_lazy_objects` disabled I get errors about it being final. When I enable `enable_native_lazy_objects` it all works fine. So if you...

@vencakrecl Could you maybe create the PR?