Ruud Kamphuis

Results 363 comments of Ruud Kamphuis

@janedbal I know you're probably very busy, but do you have advice to move this forward? Thanks. Happy to make any changes.

Thanks @janedbal for taking the time to look into this. Personally, I hope that this amazing project doesn't turn into a Deptrac 2.0. Especially since [Mago recently landed an architectural...

There is an issue going on with conditional return types. Had a few files that failed. - https://github.com/rectorphp/rector/issues/8907

Found another issue, but don't understand why it happens: ```command $ vendor/bin/phpstan analyze --debug src-dev/Rector/ /Volumes/CS/www/cosmos/src-dev/Rector/StaticMoneyConstructorRector.php PHP Fatal error: Dev\Rector\StaticMoneyConstructorRector::getRuleDefinition() has #[\Override] attribute, but no matching parent method exists in...

I was thinking about this today. With this example: ```php class MyHandler { #[AsCommandHandler] public function handle(MyCommand $command) {} } class MyCommand { public function __construct(public string $name) {} }...

Also something else I wonder, with this example: ```php class MyHandler { #[AsCommandHandler] public function handle(MyCommand $command) {} } class MyCommand { public function __construct(public string $name) {} } ```...

> First of all, please keep in mind we still work only with class methods, not classes itself. I think this is key. I forgot about that. Trying to hook...

I think we can close this. I created custom rules in our project to check if a command handler uses a command that is never dispatched. The same for event...

@jdreesen That's it indeed. I work on a library that works on PHP ^8.4. I don't want to limit newer versions, because it might just work fine. I don't like...

Is there an update on this? I noticed that I had to downgrade react/promise on my project in order to install this SDK. And now I see all kind of...