Robert Netzke
Robert Netzke
Mind if I work on this? I'm not SOB but I am doing a similar program haha
Oh got it! That is trickier to implement than I thought. Am I correct in that the `last_seen` field is only intended for mempool transactions, and would be appropriate to...
Thanks, will keep chipping at this
> If we want randomness during signing (it's a good default), then we should make the caller pass in an Rng and call: [sign_schnorr_wth_aux_rand](https://docs.rs/bitcoin/latest/bitcoin/key/struct.Secp256k1.html#method.sign_schnorr_with_aux_rand) rather than the one that needs...
> Definitely shouldn't add a dependency. I think rolling your own is the right thing to do in this case. I wonder why we would be shuffling things in BnB...
_Updated_: The PR now uses `Option` as a `SignOptions` for additional entropy on Schnorr signatures. While I think this is the lowest hanging fruit so-to-speak, I think it would be...
> TBH I'm thinking we should just drop randomness for the schnorr signing function for now (use the `no_aux_rand` function). I would prefer this. Ultimately I think this is a...
> In any case, finish can then accept an argument rng: Box, similar to what you propose, only generalized to work whenever randomness is needed. Then we add a second...
I exchanged a message with Murch on that. He said that would be a bad idea because they might end up grinding down their UTXO pool. `LargestFirst` isn't something we...
> This is sort of the vision I have in mind: Will prep this for tomorrows PR review club. There is still plenty to discuss but I think we are...