ndarray

ndarray copied to clipboard

Add From impls for CowArray, similar to Array and ArrayView

1

### Discussed in https://github.com/rust-ndarray/ndarray/discussions/1036 Originally posted by **hombit** June 18, 2021 Is there any reason why CowArray doesn't implement all `From` which is implemented by both `Array` and `ArrayView`? My...

jturner314

Use intra-doc links

2

[Intra-doc links are now stable since 1.48.0 :tada:](https://blog.rust-lang.org/2020/11/19/Rust-1.48.html#easier-linking-in-rustdoc) Using them would simplify docs. cc #558

LeSeulArtichaut

See #1027 regarding the `A: Clone` bound for `into_shared`. I've marked this PR as a draft because it would be good to add some tests using `CowArray` for methods with...

jturner314

Refine conversions between array types

2

- Move `into_shared` from `DataOwned` to `Data`, add an `A: Clone` bound, and drop the "without any copying" guarantee. (See the discussion in #1021.) - Implement `From` for more combinations...

jturner314

Fixes and follow-ups to two-sided broadcasting in arithmethic ops

1

In #898 we left the following "known issues" open that we can fix **after** that PR's review and merge: - [x] **Rename** BroadcastShape to `DimMax` - we also move the...

bluss

- `ArrayViewMut::from_shape_ptr` should make sure that elements don't alias (with at least a debug assertion). - `ArrayView::from_shape` should not check aliasing.

jturner314

I'd propose a few changes to the prelude: - [ ] Add `Order` to the prelude Rationale: `Order` will be involved in array creation, one of the most basic tasks...

bluss

Give MathCell arithmetic ops implementations when MathCell is left value

1

Update #969 Four functions are implemented for `ArrayView` in impl_methods.rs: `zip_cell_with`, `zip_cell_with_elem`, `zip_cell_with_same_shape`, `zip_cell_with_by_rows`. Operator overloading is implemented in impl_ops.rs for the following situations: `ArrayView binary_op &ArrayBase` `ArrayView binary_op Scalar`...

SparrowLii

Encode expected/actual info in ShapeError

2

Add a (limited) way to add specific information to a ShapeError Admittedly wonky, but maybe worthwhile. Result used to be 1 byte, and with this change it expands to 16...

bluss

Document every publicly visible item and add `#[warn(missing_docs)]`

1

- add `#[warn(missing_docs)]` - Document every publically visible item - until the warnings are fixed - Some items might be pub but can be downgraded to `pub (crate)` - documenting...

bluss