rust-clippy

rust-clippy copied to clipboard

Fix if_let_mutex not checking Mutexes behind refs

2

Fixes #9193 We can always peel references because we are looking for a method-call, for which autoderef applies. ``` changelog: [`if_let_mutex`]: detect calls to `Mutex::lock()` if mutex is behind a...

lukaslueg

Replace `if s.split('.').count() == 1` with `if !s.contains('.')`

5

### What it does I've found this "ingenious" snippet in a big Rust codebase, and Clippy didn't catch it. ### Lint Name str-split-count-1 ### Example ```rust if url.split('|').count() == 1...

Logarithmus

Add new lint [`positional_named_format_parameters`]

21

*Please write a short comment explaining your change (or "none" for internal only changes)* changelog: Add new lint [`positional_named_format_parameters`] to warn when named parameters in format strings are used as...

miam-miam

Implemented `suspicious_to_owned` lint to check if `to_owned` is called on a `Cow`

9

changelog: ``[`suspicious_to_owned`]`` ----------------- Hi, posting this unsolicited PR as I've been burned by this issue :) Being unsolicited, feel free to reject it or reassign a different lint level etc....

xanathar

unnecessary use of `to_string` for a type with custom `ToString` trait

1

### Summary I'm programmatically commiting a patch to a git repo and then writing the hash (a [`git2::Oid`](https://docs.rs/git2/latest/git2/struct.Oid.html)) in a file: ``` let commit = util::commit(...); fs::write(path, commit); ``` if...

xphoniex

never_loop does not understand break-with-label

10

Lint name: never_loop I tried this code: ```rust let response = 'outer: loop { for child in self.widgets.iter_mut() { if id

dhardy

`redundant_closure` fixes

6

fixes #8548 A good chunk of the code is fixing false negatives. The old code banned any non late-bound regions from appearing in the callee's signature. The new version checks...

Jarcho

### What it does For any trait bounds that's not used on the function body, create an "unused" warning ### Lint Name unused_trait_bound ### Category pedantic ### Advantage - More...

taufik-rama

### Description While trying to create a new lint, I wrote [this line](https://github.com/rust-lang/rust-clippy/blob/812db454b862b3604d6dca812cdc3c7bc740f635/clippy_lints/src/methods/collapsible_str_replace.rs#L197): ```rust let to_arg_repr_set = FxHashSet::from_iter(to_arg_reprs.iter().cloned()); ``` The feedback I received was: ```sh error: usage of `FromIterator::from_iter` -->...

nahuakang

New `[suspicious_arguments]` lint for possibly swapped arguments

4

changelog: [`suspicious_arguments`]: add lint for probably accidentally swapped arguments ---

5225225