rust-clippy

rust-clippy copied to clipboard

Suggest `.cast()` instead of `as` for pointer casts

1

### What it does Suggests using the more-scoped `cast` methods https://doc.rust-lang.org/std/primitive.pointer.html#method.cast https://doc.rust-lang.org/std/primitive.pointer.html#method.cast-1 for pointer casting instead of the more-general `as`. ### Categories (optional) - Kind: style (One could argue that...

scottmcm

New lint: potentially unwinding caller-supplied operators in `unsafe` code

21

### What it does If a non-`unsafe` generic function containing `unsafe` block uses an operator that is implemented by the caller (via `core::ops::*`) the lint warns that the operator may...

Kixunil

improve [`almost_swapped`] to look for let statement

3

fix #8151 improve [`almost_swapped`] to also detects code using let statements like ```rust let b = 1; let a = b; let b = a; let mut b = 1;...

DevAccentor

`unused_io_amount` doesn't fire when UFCS is used

1

### Summary When UFCS is used - `std::io::Read::read()` or `std::io::Write::write()` instead of a method call the lint doesn't fire even though it should for exactly the same reasons it fires...

Kixunil

### What it does It happened to me a few times that I was copy-pasting a method to make some light changes. I then renamed the method in the pasted...

jendrikw

The reason why `Drop` is a trait is because adding a `drop` method to a type is similar to implementing a trait on it. Other than that, `Drop` does not...

kadiwa4

Lint unused written length returned by `io::Write::write`

5

It's possible that this will cause partial write (depending on what `W` is), which may not be intended: ```rust use std::io; fn write_foo(w: &mut W) -> io::Result { w.write(b"foo")?; Ok(())...

sinkuu

unnecessary_unwrap: should not trigger if the `is_some` is just part of the conditional

3

`unnecessary_unwrap` recommends that `foo.is_some()` in a conditional followed by `foo.unwrap()` should be replaced by an `if let`. That is usually good advice, however, if the `is_some` is just *part* of...

nrc

`manual_flatten` false positives with reference slices

3

Lint name: manual_flatten I tried this code: ```rust struct Test { a: Option, b: Option, } fn main() { let t = Test { a: Some(1), b: Some(2), }; for...

awused

### Summary `needless_collect` doesn't consider if the iterator is borrowing values that are moved between the `collect` call and where the collected values are used. ### Lint Name needless_collect ###...

awused