backtrace-rs icon indicating copy to clipboard operation
backtrace-rs copied to clipboard

build(core): allow `windows-targets` 0.53.0

Open ErichDonGubler opened this issue 10 months ago • 3 comments

Hard dependency on https://github.com/nagisa/rust_libloading/pull/169.

ErichDonGubler avatar Jan 21 '25 20:01 ErichDonGubler

This PR is effectively ready for review, minus dependencies. A local cargo test --workspace --all-features WFM, so here's hoping CI is happy! 🤞🏻

ErichDonGubler avatar Jan 21 '25 20:01 ErichDonGubler

Looks like CI is indeed happy? Is this still a draft?

poking @ChrisDenton

workingjubilee avatar Apr 28 '25 20:04 workingjubilee

libloading 0.8.7 has been released, so this PR is now shippable.

ErichDonGubler avatar May 24 '25 13:05 ErichDonGubler

The Test (windows-latest, stable-i686-msvc) job is failing, but I'm not sure why, or how exactly to debug this. I don't have any 32-bit machines. 😅

ErichDonGubler avatar Jul 08 '25 16:07 ErichDonGubler

The Test (windows-latest, stable-i686-msvc) job is failing, but I'm not sure why, or how exactly to debug this. I don't have any 32-bit machines. 😅

Neither does CI. It cross-compiles to 32-bit. But it might just be that test is flaky again (32-bit struggles with symbolization). I'll try to look into it.

ChrisDenton avatar Jul 11 '25 20:07 ChrisDenton

Apologies for not getting to this expediently. I will likely accept https://github.com/rust-lang/backtrace-rs/pull/727 instead as it seems to implement the change preferred by @ChrisDenton

workingjubilee avatar Sep 23 '25 19:09 workingjubilee

Apologies for not getting to this expediently. I will likely accept #727 instead as it seems to implement the change preferred by @ChrisDenton

Presuming this was on account of bandwidth, I feel your pain. 🫡 At least there's good news for movement!

ErichDonGubler avatar Sep 24 '25 01:09 ErichDonGubler

bandwidth

Yep.

backtrace 0.3.76 is out and that will be the version that rust-lang/rust uses shortlyish, assuming CI passes after std integration.

workingjubilee avatar Sep 26 '25 02:09 workingjubilee