backtrace-rs icon indicating copy to clipboard operation
backtrace-rs copied to clipboard

fix clippy slow_vector_initialization

Open klensy opened this issue 1 year ago • 7 comments
trafficstars

Should be smaller code size

klensy avatar May 04 '24 10:05 klensy

Ahh, this should affect #[cfg(any(target_arch = "x86", target_arch = "arm"))] only.

klensy avatar May 04 '24 11:05 klensy

Why CI ignores changes in workflow? idk. Looks like it uses workflow from master.

klensy avatar May 04 '24 11:05 klensy

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform windows-latest:

  • Original binary size: 133,120 B
  • Updated binary size: 134,656 B
  • Difference: 1,536 B (1.15%)

github-actions[bot] avatar May 27 '24 22:05 github-actions[bot]

@klensy apparently needs imports?

workingjubilee avatar May 27 '24 22:05 workingjubilee

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform windows-latest:

  • Original binary size: 133,120 B
  • Updated binary size: 134,656 B
  • Difference: 1,536 B (1.15%)

github-actions[bot] avatar Aug 24 '24 20:08 github-actions[bot]

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md https://github.com/rust-lang/backtrace-rs/commit/18efcf9a31418c6b85900651b192217618b476cd

Looks like upload-artifact should be bumped too

klensy avatar Sep 08 '24 21:09 klensy

It was in ...

Oh we bumped download not upload.

workingjubilee avatar Sep 08 '24 21:09 workingjubilee