backtrace-rs icon indicating copy to clipboard operation
backtrace-rs copied to clipboard

Write down MSRV policy

Open workingjubilee opened this issue 2 years ago • 7 comments

This was effectively Alex Crichton's policy, so this reflects only the decision to formalize a policy.

workingjubilee avatar Aug 20 '23 05:08 workingjubilee

As this is formalizing the policy, does this need some kind of consensus from the crate maintainers team? I mean, perhaps not an fcp but maybe some LGTMs.

It doesn't really change anything, I guess, except that because backtrace was minimally maintained for quite awhile the actual msrv drifted quite a bit from the informal policy.

ChrisDenton avatar Aug 20 '23 10:08 ChrisDenton

I mean, I de facto cannot merge it without an approval and I cannot approve my own PR, so!

workingjubilee avatar Aug 20 '23 20:08 workingjubilee

For sure! I just meant like should this be a more than one approval type thing?

ChrisDenton avatar Aug 20 '23 21:08 ChrisDenton

Probably!

workingjubilee avatar Aug 20 '23 22:08 workingjubilee

@workingjubilee pseudo-fcp merge

workingjubilee avatar Aug 21 '23 21:08 workingjubilee

Team member @workingjubilee has proposed to merge this and is reusing the FCP format because it is a) funny and b) may be useful in capturing consensus. The next step is review by the rest of the tagged team members:

  • [x] @Byron
  • [x] @joshtriplett
  • [ ] @Amanieu
  • [x] @thomcc
  • [ ] @the8472
  • [x] @ChrisDenton
  • [ ] @KodrAus
  • [x] @JohnTitor
  • [x] @workingjubilee

Once a number of reviewers that seem to be "enough" approve (with maybe a few approvals outstanding), this will... probably be just merged. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/crate-maintainers: not-actually-an-FCP proposed for crate-maintainers, please feel free to register concerns. See this document for info about what commands tagged team members can give me while I am pretending to be a substitute rfcbot.

workingjubilee avatar Aug 21 '23 21:08 workingjubilee

k, calling this good enough in 10d. :^)

workingjubilee avatar Oct 02 '23 19:10 workingjubilee