Alexander Fedorov

Results 33 comments of Alexander Fedorov

> you would see that each configurable property has a getter and setter Although I don't like the "mutable struct" style of getter and setter in general, here it looks...

I would remove it and then re-contribute if really needed, but may be @jonahgraham has arguments why we should keep it.

@laeubi may be we can start from removing E3 `IMemento` We may try to replace it with E4 `MContext` in API, WDYT?

> Whatever seems sufficient, other quite obvious place would be registering Menu Contributions and the View itself... at best this would never need to surface to any API (I hope...

I'm not sure why it is is failing @HannesWell ``` 11:59:41.178 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.11-SNAPSHOT:verify (verify) on project org.eclipse.debug.core: Execute ApiApplication failed: InvocationTargetException: EmptyStackException -> [Help 1] ```

Thank you @HannesWell for your assistance. > It looks like your change is breaking API-tools^^ WOW! But that wasn't part of my plan. It looks like [this issue](https://github.com/eclipse-pde/eclipse.pde/issues/1575) was already...

After [supporting `record` for API Tools](https://github.com/eclipse-pde/eclipse.pde/pull/1598) everything is green @HannesWell

ok, a few more days for discussion and I'm going to merge it

Thank you for your feedback @HannesWell PR was reimplemented according to your comments. I'm not sure why we are fighting for reducing number of API types with adding more API...

You are right @HannesWell , it's definitely a matter of personal opinion. For me the old good Eclipse 2.0 style means a lot of static definitions, favoring of primitive types...