eclipse.platform ITerminalContextPropertiesProvider seems unused

@jonahgraham @ruspl-afed I noticed that ITerminalContextPropertiesProvider seem to have no reference, does anyone know if it is still needed?

Should we remove it (together with the extension point)?

Jul 25 '25 04:07 laeubi

I would remove it and then re-contribute if really needed, but may be @jonahgraham has arguments why we should keep it.

Jul 25 '25 07:07 ruspl-afed

There are active users of it (in the old namespace) within active Eclipse ecosystem, for example in TCF https://gitlab.eclipse.org/eclipse/tcf/tcf/-/blob/master/target_explorer/plugins/org.eclipse.tcf.te.tcf.locator/src/org/eclipse/tcf/te/tcf/locator/services/TerminalContextPropertiesProvider.java

Note that TCF was the originator of the terminal and TCF is still actively maintained and used.

Jul 28 '25 16:07 jonahgraham

@jonahgraham should TCF probably also be migrated to the new terminal view then?

Jul 28 '25 17:07 laeubi

Yes, but I don't know when it should happen. In the past tcf have tried to maintain a wide support window, so they may hold off updating for a while. They have had this same class deal with major version changes in the past.

Jul 28 '25 17:07 jonahgraham

I think I might can add support for them with the compatibility bundle if they are interested and help in testing that...

Jul 28 '25 17:07 laeubi