Rushat Gabhane comments

Results 296 comments of


                                            Rushat Gabhane

Updating to 3.7 and current issues

@gmanc2 feel free to submit PRs. It should help everyone

[HOLD PR #10965][$250] mWeb/Chrome - Workspace - Unable to use Enter key for starting a new line under Personal message box

> https://github.com/Expensify/App/issues/10906#issuecomment-1245190241 cc @Expensify/design

[$250] BUG: Checkbox current state is not saved in draft on Connect bank account page reported by @parasharrajat

### Proposal #### Context This is occuring on connect bank and add debit card page. Both have a `CheckboxWithLabel` that uses `Form`. 1. Form gets the `draftValue` from here -...

[$250] BUG: Checkbox current state is not saved in draft on Connect bank account page reported by @parasharrajat

oh haha, posted the same thing on slack. agree with @parasharrajat

[$250] BUG: Checkbox current state is not saved in draft on Connect bank account page reported by @parasharrajat

> Passed inputId and shouldsaveDraft props to Checkbox component is deceiving and wrong. nice catch, Rajat 🙌

[$250] BUG: Checkbox current state is not saved in draft on Connect bank account page reported by @parasharrajat

> was this a regression or just something that was missed during the initial implementation Not a regression 😄 it was missed during the initial implementation.

[$500] Bug: You can't search a room with names like "x.y" reported by @Puneet-here

The bug makes sense to me. Workspace names could have the company's domain name in it. @roryabraham I like @0xmiroslav's [proposal](https://github.com/Expensify/App/issues/12026#issuecomment-1287124501). 🎀 👀 🎀 C+ reviewed

[$250] Try to copy and paste an emoji from Slack into the chat editor shows an error

reviewing today

[$250] Try to copy and paste an emoji from Slack into the chat editor shows an error

@0xmiroslav question: don't we need to fix this issue for native too?

[$250] Try to copy and paste an emoji from Slack into the chat editor shows an error

~@0xmiroslav Thanks for the confirmation!~ ~@srikarparsi I like @0xmiroslav's [proposal](https://github.com/Expensify/App/issues/9505#issuecomment-1295455119).~ ~🎀 👀 🎀 C+ reviewed~