Evan Rusackas
Evan Rusackas
@gooroodev please review
I tried to have Claude (AI) review this, but it's too large. Even the smallest of the individual files' diffs was too large :P
Re-running that test. Hopefully it's just flaky. Thank you for simplifying the PR!
Ok, here's some AI-generated feedback. Let me know your thoughts :) > > "% calculation" is translated as "Расчет долей" which means "Share calculation". It seems like an odd translation...
Possibly related to (or even a duplicate of?) https://github.com/apache/superset/issues/29324
These all seem like they might effectively be the same issue: https://github.com/apache/superset/issues/29394 https://github.com/apache/superset/issues/31158 https://github.com/apache/superset/issues/29719 https://github.com/apache/superset/issues/28713 https://github.com/apache/superset/issues/27532 Can anyone here test this with DASHBOARD_VIRTUALIZATION set to `false`? I have a suspicion...
We're no longer supporting 3.x, and this has been silent for a long time. Closing this, but if it's still happening somehow in 4.1.1, please add some updated context, and...
Looks like `css-font-parser` is making into `package-lock.json` and has an incompatible license. Any way to get rid of that?
> @rusackas There is an invalid spdx identifier in css-font-parser, but the license itself is compatible (BSD-3-Clause). I created a PR a while ago to solve the issue https://github.com/bramstein/css-font-parser/pull/11 but...
I'm excited we can likely get this into 5.0!