Evan Rusackas comments

Results 1381 comments of


                                            Evan Rusackas

docs: Check markdown files for bad links using linkinator

Thanks for the approval, but this is only the tip of the iceberg :) This found (if memory serves) something like 34 links that need to be addressed. These will...

docs: Check markdown files for bad links using linkinator

I mean... it seems like it'll let us merge with the test failing as-is, but that seems like bad hygiene for other PRs that follow before I clean up my...

Installing error

Upgrading npm and node will likely be part of Superset 5.0. We just upgraded it, so we're letting that soak before we do it again. I _think_ core-js is a...

fix: Add back description column to saved queries #12431

The tooltip looks strangely high up, otherwise we're looking good, and thanks for the touchup! I'll try to find time in a bit to pull your branch and see about...

fix: Add back description column to saved queries #12431

OK, I think we're good to go otherwise... I'll await feedback before unilaterally merging. I think Truthfulness outweighs Consitency, which outweighs pretty much any other random change ;)

Superset Guest Token Endpoint Only is not Working My URL - ( https://superset.mysite.com/api/v1/security/guest_token )

Any reproduction steps whatsoever would help someone understand what you're up against. We don't know how you're deploying Superset, how you're embedding it, what role you're using for the guest...

Add documentation for `HTTP::WebSocket#stream`

Ahh yes.. the crossfilter actually changes the data being fed to the table, so the total is calculated. The filter IN the table doesn't appear to recalculate on the fly....

Bar chart - Impossible to maintain consistent bar width with sparse data

Hmm... I can't play the video for some reason. :/

build(deps): bump rimraf from 3.0.2 to 5.0.5 in /superset-frontend

I think this one actually needs an import change before merging

fix(ci): run frontend actions based on master, not the fork.

@mistercrunch fixed! (cc @michael-s-molina since we discussed this earlier)