Evan Rusackas comments

Results 1381 comments of


                                            Evan Rusackas

Database Locks are accumulating in the Superset database up to 'sqlalchemy.exc.TimeoutError: QueuePool limit of size 5 overflow 10 reached'

Can't say I've run into this one. Assigning to @betodealmeida, but curious if @villebro or @mistercrunch have any advice here.

Database Locks are accumulating in the Superset database up to 'sqlalchemy.exc.TimeoutError: QueuePool limit of size 5 overflow 10 reached'

This has been silent for quite a while... sounds like it's closeable?

Database Locks are accumulating in the Superset database up to 'sqlalchemy.exc.TimeoutError: QueuePool limit of size 5 overflow 10 reached'

Should we oen that PR to set max_overflow to -1 by default? I think that came up on another issue as well.

can read on Row Level Security / can read on RowLevelSecurity

We suspect both are indeed needed... to consolidate these would be a breaking change and require a migration. We could consider this for the next major release.

messages.pot had unuseful "#, python-format"

@dosu do you think there's any way to grep for this, or have the .pot extraction script correct for it?

fix(chart): Fix the problem that chart legend resets after user scrolls down

Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following: ``` pip3 install -r requirements/development.txt pre-commit install ``` A series of checks will now run when you...

fix(chart): Fix the problem that chart legend resets after user scrolls down

Thanks for taking care of so many of the review comments. Added a comment elsewhere, but in re-reviewing this, I'm noticing that a lot of `JSON.parse` is being used here...

fix(chart): Fix the problem that chart legend resets after user scrolls down

Hey again, I was looking at this a bit over the weekend, and wondering if this is the right approach for this, really. It seems that there are a few...

fix(chart): Fix the problem that chart legend resets after user scrolls down

OK, here's the big diff it provided. It claims this will do what I was mentioning, and • Keep chart localStorage persistence per chart • Clean up all chart legend...

fix(chart): Fix the problem that chart legend resets after user scrolls down

Heya! This is MUCH cleaner! Might you (and your team) have time to actually sync up on this? I spoke with some other reviewers on zoom, and the consenus thought...